[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add a test case that validates save to a block device



On 04/21/2010 11:03 AM, Daniel P. Berrange wrote:
> There are some unusual problems when saving to a block device,
> vs a file. This test case covers problems inherant in using

s/inherant/inherent/

> block devices
> ---
>  scripts/domain/103-blockdev-save-restore.t |   91 ++++++++++++++++++++++++++++
>  1 files changed, 91 insertions(+), 0 deletions(-)
>  create mode 100644 scripts/domain/103-blockdev-save-restore.t
> 
> diff --git a/scripts/domain/103-blockdev-save-restore.t b/scripts/domain/103-blockdev-save-restore.t
> new file mode 100644
> index 0000000..3cacc2f
> --- /dev/null
> +++ b/scripts/domain/103-blockdev-save-restore.t
> @@ -0,0 +1,91 @@
> +# -*- perl -*-
> +#
> +# Copyright (C) 2009-2010 Red Hat, Inc.
> +# Copyright (C) 2009 Daniel P. Berrange

Since it's a new file, shouldn't this just be 2010?

Beyond that, it looks okay to me (perl is still not my strongest
language, but I'm getting better as I read through more of the TCK).

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]