[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/10] Qemu arbitrary monitor commands.



On 04/21/2010 10:01 AM, Chris Lalancette wrote:
> Implement the qemu driver's virDomainQemuMonitorCommand
> and hook it into the API entry point.
> 
>  
> +int qemuMonitorCommand(virDomainPtr domain, const char *cmd,
> +                       char **result, unsigned int flags ATTRIBUTE_UNUSED)
> +{
> +    struct qemud_driver *driver = domain->conn->privateData;
> +    virDomainObjPtr vm = NULL;
> +    int ret = -1;
> +    qemuDomainObjPrivatePtr priv;

virCheckFlags() to reject unknown flags, rather than ignoring it.

Other than this, it looks clean to me, so ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]