[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix initial VCPU pinning in qemu driver



> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 5f4adfd..cc3e3b2 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -3081,10 +3081,10 @@ static int qemudSecurityHook(void *data) {
> >      /* This must take place before exec(), so that all QEMU
> >       * memory allocation is on the correct NUMA node
> >       */
> > -    if (qemudInitCpuAffinity(h->vm) < 0)
> > +    if (qemuAddToCgroup(h->driver, h->vm->def) < 0)
> >          return -1;
> >  
> > -    if (qemuAddToCgroup(h->driver, h->vm->def) < 0)
> > +    if (qemudInitCpuAffinity(h->vm) < 0)
> >          return -1;
> >  
> >      if (h->driver->securityDriver &&
> 
> ACK, but can you add a comment in the code too, that the cpuaffinity 
> setup must come after the cgroup placement.

OK, I added the comment there and pushed. Thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]