[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Poll for migration end every 50ms instead of 50us



On Thu, Apr 22, 2010 at 04:34:54PM +0200, Jiri Denemark wrote:
> The comment in qemuDomainWaitForMigrationComplete says we are polling
> every 50ms but the code sleeps only for 50us. This was already discussed
> during review but apparently forgotten when the series was pushed.
> ---
>  src/qemu/qemu_driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 89cd291..4afed2f 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4524,7 +4524,7 @@ qemuDomainWaitForMigrationComplete(struct qemud_driver *driver, virDomainObjPtr
>  
>      while (priv->jobInfo.type == VIR_DOMAIN_JOB_UNBOUNDED) {
>          /* Poll every 50ms for progress & to allow cancellation */
> -        struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000ull };
> +        struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000 * 1000ull };
>          struct timeval now;
>          int rc;

  Oh, yes I remember,

ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]