[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] configure.ac SELinux fixes



On 04/21/2010 11:44 AM, spencer beyondabstraction net wrote:
> * Fix a logic error in configure.ac that prevented --with-selinux=no from being used with --with-secdriver-selinux=no.
> 
> * Fix some strings to clarify the difference between --with-selinux and --with-secdriver-selinux.
> 
> @@ -891,9 +891,9 @@ AC_ARG_WITH([secdriver-selinux],
>  if test "$with_selinux" != "yes" ; then
>    if test "$with_secdriver_selinux" = "check" ; then
>      with_secdriver_selinux=no
> -  else
> -    AC_MSG_ERROR([You must install the SELinux development package in order to compile libvirt])
> -  fi
> +  elif test "$with_secdriver_selinux" = "yes"; then
> +        AC_MSG_ERROR([You must install the libselinux development package and enable SELinux with the --with-selinux=yes in order to compile libvirt --with-secdriver-selinux=yes])
> +  fi 

ACK on the logic fix, and the error message changes seemed okay.

Your git configuration might be off: you sent from a different email
address than your signed-off line, and with no associated name, which
confused git am.  I ended up manually setting the commit Author: field
to match your signed-off line.  I also had to fix a trailing whitespace
bug, in order to pass 'make syntax-check'.  But after that, I went ahead
and pushed this; thanks again for the patch.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]