[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix security context references in DAC code

On 04/21/2010 11:44 AM, spencer beyondabstraction net wrote:
> * The error messages coming from qemu's DAC support contain strings from the original SELinux security driver code.  This just removes references to "security context" and other SELinux-isms from the DAC code.

That's a long line; feel free to wrap your commit messages anywhere
between 70 and 80 columns.

> @@ -37,7 +37,7 @@ void qemuSecurityDACSetDriver(struct qemud_driver *newdriver)
>  static int
>  qemuSecurityDACSetOwnership(const char *path, int uid, int gid)
>  {
> -    VIR_INFO("Setting DAC context on '%s' to '%d:%d'", path, uid, gid);
> +    VIR_INFO("Setting DAC user and group on '%s' to '%d:%d'", path, uid, gid);

Yep, obvious cut-and-paste going on there, before the patch.

ACK, and pushed.  Thanks again for the patch.

I'm also pushing a followup patch to update AUTHORS with seven recent
patch contributors (to avoid posting raw email addresses for spammers to
harvest, I won't post that patch to the list unless specifically
requested).  I think that qualifies as obvious, using the formula:

git shortlog $(git log -1 --format=%H AUTHORS).. | grep -v "^ "

and adding all authors that aren't already listed.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]