[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: don't include winsock2.h on cygwin



2010/4/23 Eric Blake <eblake redhat com>:
> Under cygwin, winsock2.h is intentionally incompatible with,
> <sys/socket.h>, and checking for existence is wrong.
>
> Under mingw, HAVE_WINSOCK2_H is defined on our behalf by
> gnulib, in a way that does not interfere with cygwin.
>
> * configure.ac: Drop unnecessary header check.
> Reported by Matthias Bolte.
> ---
>  configure.ac |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 99bc906..deaa697 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -112,7 +112,8 @@ dnl Availability of various not common threadsafe functions
>  AC_CHECK_FUNCS([strerror_r strtok_r getmntent_r getgrnam_r getpwuid_r])
>
>  dnl Availability of various common headers (non-fatal if missing).
> -AC_CHECK_HEADERS([pwd.h paths.h regex.h sys/syslimits.h sys/utsname.h sys/wait.h winsock2.h sched.h termios.h sys/poll.h syslog.h mntent.h net/ethernet.h])
> +AC_CHECK_HEADERS([pwd.h paths.h regex.h sys/syslimits.h sys/utsname.h
> +  sys/wait.h sched.h termios.h sys/poll.h syslog.h mntent.h net/ethernet.h])
>
>  dnl Where are the XDR functions?
>  dnl If portablexdr is installed, prefer that.
> --
> 1.6.6.1
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]