[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] Fix up the error message if we can't parse the snapshot XML.



2010/4/23 Chris Lalancette <clalance redhat com>:
> Signed-off-by: Chris Lalancette <clalance redhat com>
> ---
>  src/conf/domain_conf.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 6dc26c3..139712a 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -6614,8 +6614,7 @@ virDomainSnapshotDefPtr virDomainSnapshotDefParseString(const char *xmlStr,
>     }
>
>     if (!xmlStrEqual(root->name, BAD_CAST "domainsnapshot")) {
> -        virDomainReportError(VIR_ERR_INTERNAL_ERROR,
> -                              "%s", _("incorrect root element"));
> +        virDomainReportError(VIR_ERR_XML_ERROR, "%s", _("domainsnapshot"));
>         goto cleanup;
>     }
>

Could we have a bit more verbose error message here, like "unknown
root element for domain snapshot"?

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]