[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/8] Fix virDomainSnapshotObjFree memory leak.



2010/4/23 Chris Lalancette <clalance redhat com>:
> We were freeing the virDomainSnapshotDefPtr, but not
> the virDomainSnapshotObjPtr in virDomainSnapshotObjFree.
>
> Signed-off-by: Chris Lalancette <clalance redhat com>
> ---
>  src/conf/domain_conf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 139712a..3ad24cb 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -6754,6 +6754,7 @@ static void virDomainSnapshotObjFree(virDomainSnapshotObjPtr snapshot)
>     VIR_DEBUG("obj=%p", snapshot);
>
>     virDomainSnapshotDefFree(snapshot->def);
> +    VIR_FREE(snapshot);
>  }
>
>  int virDomainSnapshotObjUnref(virDomainSnapshotObjPtr snapshot)
> --
> 1.6.6.1
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]