[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] nwfilter: enable hex number inputs in filter XML



On 04/26/2010 11:29 AM, Stefan Berger wrote:
> With this patch I want to enable hex number inputs in the filter XML. A
> number that was entered as hex is also printed as hex unless a string
> representing the meaning can be found.
> 
> I am also extending the schema and adding a test case. A problem with
> the DSCP value is fixed on the way as well.
> 
> Changes from V1 to V2:
> 
> - using asHex boolean in all printf type of functions to select the
> output format in hex or decimal format

ACK - I'm fine with either version as long as gcc doesn't complain, but
now that you've done the work, you might as well check in v2.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]