[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] desactivate lxc and qemu support on non-linux systems



On Mon, Apr 26, 2010 at 08:44:29PM +0200, Matthias Bolte wrote:
> 2010/4/26 Eric Blake <eblake redhat com>:
> > On 04/26/2010 07:41 AM, Daniel Veillard wrote:
> >>   note that with_qemu is set to yes by default
> >>
> >>
> >> Daniel
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index 99bc906..d360b4e 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -205,6 +205,18 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then
> >>      sysconfdir='/etc'
> >>  fi
> >>
> >> +dnl lxc and qemu drivers require linux headers
> >> +if test `uname -s` != "Linux"
> >> +then
> >> +    if test "x$with_lxc" != "xyes"
> >> +    then
> >> +        with_lxc=no
> >> +    fi
> >> +    if test "x$with_qemu" != "xyes"
> >> +    then
> >> +        with_qemu=no
> >> +    fi
> >> +fi
> >
> > ACK, unless Matthias' recent patches to configure.ac already covered
> > this in another manner.
> >
> 
> ACK.
> 
> I saw this problem too, but didn't post a patch for it yet. I posted a
> patch related to this that improved the error message and made it
> saying that Linux kernel headers are required for QEMU and LXC
> support.

  okay, pushed,

> Actually with some recent changes from Stefan, Linux kernel headers
> are now always required when compiling on/for Linux because
> src/util/interface.c includes linux/if.h.

with_bridge=no
if test "$with_qemu:$with_lxc:$with_network" != "no:no:no"; then
    with_bridge=yes
    AC_DEFINE_UNQUOTED([WITH_BRIDGE], 1, [whether bridge code is needed])
fi
AM_CONDITIONAL([WITH_BRIDGE], [test "$with_bridge" = "yes"])

 that seems to imply network support would have to be disabled on
Solaris, as the bridge.c is full of linux includes.

Mutipath code is also linux only (no surprise)

For interface I now see

#ifdef __linux__
# include <linux/if.h>
#endif

  so that probably compile there now.

Someone has an OpenSolaris VM to try to get the build through ?

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]