[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Internal driver API infrastructure for virDomainGetBlockInfo



On 04/27/2010 01:34 PM, Daniel P. Berrange wrote:
> This defines the internal driver API and stubs out each driver
> 
> * src/driver.h: Define virDrvDomainGetBlockInfo signature
> * src/libvirt.c, src/libvirt_public.syms: Glue public API to drivers
> * src/esx/esx_driver.c, src/lxc/lxc_driver.c, src/opennebula/one_driver.c,
>   src/openvz/openvz_driver.c, src/phyp/phyp_driver.c,
>   src/test/test_driver.c, src/uml/uml_driver.c, src/vbox/vbox_tmpl.c,
>   src/xen/xen_driver.c, src/xenapi/xenapi_driver.c: Stub out driver
...
> +/**
> + * virDomainGetBlockInfo:
> + * @domain: a domain object
> + * @path: path to the block device or file
> + * @info: pointer to a virDomainBlockInfo structure allocated by the user

Document that flags is 0 for now?

> + *
> + * Extract information about a domain's block device.
> + *
> + * Returns 0 in case of success and -1 in case of failure.
> + */
> +int
> +virDomainGetBlockInfo(virDomainPtr domain, const char *path, virDomainBlockInfoPtr info, unsigned int flags)
> +{
> +    virConnectPtr conn;
> +    DEBUG("domain=%p, info=%p", domain, info);

List flags in the DEBUG.

ACK with those nits addressed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]