[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] build: fix python in VPATH build



Eric Blake wrote:
> Match the fact that docs/Makefile.am dumps libvirt-api.xml in the
> build dir, not the source dir.
>
> * python/Makefile.am (API_DESC): Point make to the builddir for .xml files.
> * python/generator.py (buildStubs): Output in correct location.

Hi Eric,

Does this fix a failure or just ensure that we use more
up to date .xml files?

With just your cfg.mk patch, I ran a srcdir ./autogen.sh && make distclean
followed by "make check syntax-check" from a non-srcdir build dir.
It succeeded.

The only potential down-side I see is that this requires running Python
(though only in a VPATH build?), to recreate a distributed file that is
available in $(srcdir).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]