[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix autogen rule for VPATH build



On Wed, Apr 28, 2010 at 12:17:43PM +0200, Jim Meyering wrote:
> Eric Blake wrote:
> > +      cd '$(srcdir)';							\
> >        actual=$$(git submodule status | $(_submodule_hash);		\
> >  		git hash-object bootstrap.conf;				\
> >  		git diff .gnulib);					\
> 
> ACK.
> FYI, I never encountered a need for that "cd" before, in testing VPATH
> builds, because my first step was always to run ./autogen.sh && distclean
> from the srcdir, not realizing that e.g., ../autogen.sh (from the build
> dir) was supposed to work, too.

  BTW since we have auto* experts around, I tend to use the CDPATH
environment variable to make navigation within my tree easier,
but has a tendency to break some of the auto* target, because as a
result the cd command outputs the target directory instead of being
silent. This used to break for example "make dist" in subtle ways.
If you see the Makefile.am rpm target that I use commonly, I added
the unset there, but it may be nicer to actually fix auto* :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]