[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix build on Ubuntu.



On 04/28/2010 02:27 PM, Chris Lalancette wrote:
> When building on Ubuntu with make -j3 (or more), it would always
> fail when trying to build virt-aa-helper.  I'm not an expert in
> automake by any means, but I think the entry for virt-aa-helper
> is mis-using LDADD; it shouldn't be putting direct paths to
> libvirt_conf.la and libvirt_util.la, but instead referencing those
> names.  With this patch in place, I'm able to successfully build
> on Ubuntu 9.04 with make -j3.

The patch is correct.  Automake can't see through the @top_srcdir@
indirection (for that matter, automake much prefers to use
$(top_srcdir), not @top_srcdir@); but does have magic in place to build
correctly with the simpler names even across VPATH trees.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]