[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/2] build: fix VPATH build of docs



Eric Blake wrote:
> The rule of thumb for generated files:
> If they are distributed, they should be generated in $(srcdir);
> otherwise, they should be built by the end user in $(builddir).
> Since our .xml docs are built with python, and we want them
> available even to end users that don't build with python, we
> want them distributed; hence, they must live in $(srcdir).
>
> Tested with 'make distcheck' in both an in-tree build and a
> VPATH build.
>
> * docs/Makefile.am (EXTRA_DIST): Remove redundant listing of xml
> files.
> ($(devhelphtml)): Since we distribute .xml, build it in srcdir.
> (html/%-%.html, html/%-virterror.html, %-api.xml, %-refs.xml):
> Rewrite with...
> (python_generated_files): ...new macro.
> (libvirt-api.xml, libvirt-refs.xml): ...longhand.
> (api, web, html/index.html, maintainer-clean-local):
> (html/index.html, %.html.tmp, %.html): Update location.
> (dot_html_in, patches): Massage wildcard correctly.
> * docs/apibuild.py (docBuilder.serialize): Put output in srcdir.
> (docBuilder.serialize_xrefs_references): Update location.
> (rebuild): Look for built libvirt.h in builddir.
> * .gitignore: Ignore 'make distcheck' crumbs.

This all looks good.  Thanks!
ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]