[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add support for another explicit IO error event



On Thu, Apr 29, 2010 at 05:44:28PM +0100, Daniel P. Berrange wrote:
> This introduces a new event type
> 
>    VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON
> 
> This event is the same as the previous VIR_DOMAIN_ID_IO_ERROR
> event, but also includes a string describing the cause of
> the event.
> 
> Thus there is a new callback definition for this event type
> 
> typedef void (*virConnectDomainEventIOErrorReasonCallback)(virConnectPtr conn,
>                                                            virDomainPtr dom,
>                                                            const char *srcPath,
>                                                            const char *devAlias,
>                                                            int action,
>                                                            const char *reason,
>                                                            void *opaque);
> 
> This is currently wired up to the QEMU block IO error events
> 
> * daemon/remote.c: Dispatch IO error events to client
> * examples/domain-events/events-c/event-test.c: Watch for
>   IO error events
> * include/libvirt/libvirt.h.in: Define new IO error event ID
>   and callback signature
> * src/conf/domain_event.c, src/conf/domain_event.h,
>   src/libvirt_private.syms: Extend API to handle IO error events
> * src/qemu/qemu_driver.c: Connect to the QEMU monitor event
>   for block IO errors and emit a libvirt IO error event
> * src/remote/remote_driver.c: Receive and dispatch IO error
>   events to application
> * src/remote/remote_protocol.x: Wire protocol definition for
>   IO error events
> * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h,
>   src/qemu/qemu_monitor_json.c: Watch for BLOCK_IO_ERROR event
>   from QEMU monitor

  Okay, while a new API, I don't see how this could break existing
support,

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]