[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Restrict vpx:// to handle a single host in a vCenter

2010/8/2 Daniel Veillard <veillard redhat com>:
> On Sun, Aug 01, 2010 at 02:20:22AM +0200, Matthias Bolte wrote:
>> Now a vpx:// connection has an explicitly specified host. This
>> allows to enabled several functions for a vpx:// connection
>> again, like host UUID, hostname, general node info, max vCPU
>> count, free memory, migration and defining new domains.
>> Lookup datacenter, compute resource, resource pool and host
>> system once and cache them. This simplifies the rest of the
>> code and reduces overall HTTP(S) traffic a bit.
>> esx:// and vpx:// can be mixed freely for a migration.
>> Ensure that migration source and destination refer to the
>> same vCenter. Also directly encode the resource pool and
>> host system object IDs into the migration URI in the prepare
>> function. Then directly build managed object references in
>> the perform function instead of re-looking up already known
>> information.
>> ---
>>  docs/drvesx.html.in          |   33 +++-
>>  src/esx/esx_driver.c         |  360 ++++++++++----------------
>>  src/esx/esx_storage_driver.c |   24 +--
>>  src/esx/esx_vi.c             |  588 ++++++++++++++++++++++++++----------------
>>  src/esx/esx_vi.h             |   26 ++-
>>  src/esx/esx_vmx.c            |    4 +
>>  6 files changed, 561 insertions(+), 474 deletions(-)
>  Humpf, that was big !
> it seems to me that this change the behaviour of vServer access, so
> I'm tempted to get this pushed in 0.8.3, rather than wait for the next
> version to change things. On one hand this breaks the freeze, but
> this is focused to one specific kind of hypervisor whose support is
> being added, so I think this is fine to push before the release if you
> agree,
> Daniel

This patch is the reason that I asked you to delay 0.8.3 a bit. Prior
to this patch you could connect to a whole vCenter, this resulted in
multiple problems as you already saw in the initial vCenter patch. The
bunch of "TODOs without an error message". Also Dan pointed out that
being able to connect to a whole vCenter is probably out of libvirt's

With this patch the vCenter connection is restricted to a single ESX
server. This solves all the "TODOs without an error message".
Including the patch into 0.8.3 makes sure that we have the opportunity
to relax the restrictions on a vCenter connection later on (if that
turns out to be to be feasible), instead of having to apply
restrictions in later releases.

The other 4 patches just came along with this one, and I'd like to
include all 5 into 0.8.3.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]