[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build-sys: fix build when daemon is disabled by not installing libvirtd.8



On 08/05/2010 07:17 PM, Diego Elio Pettenò wrote:
> Since the rule to build libvirtd.8 is within the WITH_LIBVIRTD conditional,
> so declare the man page in there as well. Without this change, build
> without daemon will fail.
> ---
>  .gnulib            |    2 +-
>  daemon/Makefile.am |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/.gnulib b/.gnulib
> index 1629006..11fbc57 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 1629006348e1f66f07ce3ddcf3ebd2d14556cfce
> +Subproject commit 11fbc57405a118e6ec9a3ebc19bbf5ececdae4d6

Was this intentional?  I'm assuming it was accidental, and omitting it.

> diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> index 963d64f..dbf0ac3 100644
> --- a/daemon/Makefile.am
> +++ b/daemon/Makefile.am
> @@ -41,12 +41,12 @@ EXTRA_DIST =						\
>  	$(AVAHI_SOURCES)				\
>  	$(DAEMON_SOURCES)
>  
> -man_MANS = libvirtd.8
> -
>  BUILT_SOURCES =
>  
>  if WITH_LIBVIRTD
>  
> +man_MANS = libvirtd.8
> +
>  sbin_PROGRAMS = libvirtd

ACK; applied.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]