[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] phyp: Fixing possible buffer overflow



 On 08/05/2010 10:09 PM, Eric Blake wrote:
On 08/05/2010 07:49 PM, Laine Stump wrote:
+        if (virStrToLong_i(line,&next_line, 10,&ids[got]) == -1) {
+            VIR_ERROR(_("Cannot parse number from '%s'"), line);
+            got = -1;
+            goto err;
     err:
       VIR_FREE(cmd);
       VIR_FREE(ret);
-    return -1;
+    return got;
   }
Before, this always returned -1 on failure.  But now, if you parse one
line before failing to parse the second, it returns 1.  I think the err:
label should continue to return -1 on failure.

But right before the goto err; there is a "got = -1;" Am I missing
something?
Nope - I was missing the got = -1.  Thanks; no change needed.

Okay, based on Eduardo's report of success, and your approval, I pushed the patch. Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]