[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] bootloader_args is named bootargs in xen-xm



On 08/05/2010 09:07 AM, Philipp Hahn wrote:
> According to <xen-3.4.3/tools/python/xen/xm/create.py:158>
> 	gopts.var('bootargs', val='NAME',
> 			  fn=set_value, default=None,
> 			  use="Arguments to pass to boot loader")
> the "bootloader_args" parameter needs to be translated into "bootargs"
> when using "virsh domxml-to-native xen-xm".
> The reverse direction (domxml-from-native) is already okay.
> 
> This patch fixes domxml-to-native and adds two test files to catch this
> problem.
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  src/xen/xm_internal.c                          |    2 +-
>  tests/xmconfigdata/sexpr2xml-pv-bootloader.cfg |   12 +++++++++++
>  tests/xmconfigdata/sexpr2xml-pv-bootloader.xml |   26 
> ++++++++++++++++++++++++

Looks reasonable; applied after removing a trailing line that broke
'make syntax-check'.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]