[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 3/3] Remove wrong check for uml monitor response size



The current check for the size of the response from the uml monitor is
problematic for a couple of reasons:

First of all, for me, the call to recvfrom returns 0, even though the
buffer actually is populated with the response from the monitor.

Second, it seems to me that (assuming recvfrom actually returned the
number of bytes read) it should be compared against the size of the
response header plus the actual data length rather than the max size of
the datagram.

At any rate, the only way I can get anything useful to happen here is to
completely remove the check, so this patch does just that.

Signed-off-by: Soren Hansen <soren linux2go dk>
---
 src/uml/uml_driver.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index 04493ba..9cf669f 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -737,10 +737,6 @@ static int umlMonitorCommand(const struct uml_driver *driver,
             virReportSystemError(errno, _("cannot read reply %s"), cmd);
             goto error;
         }
-        if (nbytes < sizeof res) {
-            virReportSystemError(0, _("incomplete reply %s"), cmd);
-            goto error;
-        }
         if (sizeof res.data < res.length) {
             virReportSystemError(0, _("invalid length in reply %s"), cmd);
             goto error;
-- 
1.7.0.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]