[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix tunnelled migration with qemu running as qemu:qemu.



On 08/12/2010 08:25 AM, Chris Lalancette wrote:
> The problem is that on the source of the migration, libvirtd
> is responsible for creating the unix socket over which the data
> will flow.  Since libvirtd is running as root, this file will
> be created as root.  When the qemu process running as qemu:qemu
> goes to access the unix file to write data to it, it will get
> permission denied and fail.  Make sure to change the owner
> of the unix file to qemu:qemu.
> 
> Thanks to Justin Clift for testing this patch out for me.
> 
> Signed-off-by: Chris Lalancette <clalance redhat com>
> ---
>  src/qemu/qemu_driver.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 3dfd1ae..b6b6633 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10975,6 +10975,13 @@ static int doTunnelMigrate(virDomainPtr dom,
>          goto cleanup;
>      }
>  
> +    if (chown(unixfile, qemu_driver->user, qemu_driver->group) < 0) {
> +        virReportSystemError(errno,
> +                             _("Cannot change unix socket '%s' owner"),
> +                             unixfile);
> +        goto cleanup;
> +    }

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]