[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Move the tunnelled migration unix socket to /var/lib/libvirt/qemu



On Thu, Aug 12, 2010 at 12:57:58PM -0400, Chris Lalancette wrote:
> Since the qemu process is running as qemu:qemu, it can't actually
> look at the unix socket in /var/run/libvirt/qemu which is owned by
> root and has permission 700.  Move the unix socket to
> /var/lib/libvirt/qemu, which is already owned by qemu:qemu.
> 
> Thanks to Justin Clift for test this out for me.
> 
> Signed-off-by: Chris Lalancette <clalance redhat com>
> ---
>  src/qemu/qemu_driver.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index b6b6633..007b09a 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10470,7 +10470,7 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn,
>      vm->def->id = -1;
>  
>      if (virAsprintf(&unixfile, "%s/qemu.tunnelmigrate.dest.%s",
> -                    driver->stateDir, vm->def->name) < 0) {
> +                    driver->libDir, vm->def->name) < 0) {
>          virReportOOMError();
>          goto endjob;
>      }
> @@ -10941,7 +10941,7 @@ static int doTunnelMigrate(virDomainPtr dom,
>      /* Stage 1. setup local support infrastructure */
>  
>      if (virAsprintf(&unixfile, "%s/qemu.tunnelmigrate.src.%s",
> -                    driver->stateDir, vm->def->name) < 0) {
> +                    driver->libDir, vm->def->name) < 0) {
>          virReportOOMError();
>          goto cleanup;
>      }

ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]