[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] nwfilter:



Incomplete subject line?  It used to be
 nwfilter: extend nwfilter reload support

On 08/13/2010 02:29 PM, Stefan Berger wrote:
>  v3:
>     - Fixed an indentation problem
>     - added bool parameter to function terminating the IP address
> learner threads to determine whether future threads may still run
> (needed in case of driver reload) or all must terminate (need in case of
> libvirtd termination)
> 

> +    conn = virConnectOpen("qemu:///system");
> +
> +    if (conn) {
> +        /* shut down all threads -- qemud for example will restart them */
> +        virNWFilterLearnThreadsTerminate(true);
> +
> +        nwfilterDriverLock(driverState);
> +        virNWFilterPoolLoadAllConfigs(conn,
> + &driverState->pools,

Indentation problem still looks like it is here.

> @@ -1912,7 +1926,11 @@ qemudStartup(int privileged) {
>                                  1, NULL, NULL) < 0)
>          goto error;
> 
> -    qemuReconnectDomains(qemu_driver);
> +    conn = virConnectOpen(qemu_driver->privileged ?
> +                          "qemu:///system" :
> +                          "qemu:///session");

How come this one is conditional, but the other one was hard-coded to
system?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]