[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: allow mingw VPATH build

On 08/14/2010 12:37 PM, Matthias Bolte wrote:
> 2010/8/14 Eric Blake <eblake redhat com>:
>> * .gnulib: Update to latest.
>> Reported by Matthias Bolte.
>> ---
>> Mainly for the top one, but there are a couple of relevant
>> upstream patches in this list.
>> * .gnulib 1629006...7ba06c8 (152):
>>  > pthread: fix pthread.h creation for srcdir != builddir
> ACK.

Thanks; pushed.

On a related note:  On IRC, you mentioned that you encountered an
inf-loop for make and autogen.sh when you had local modifications in
your .gnulib file.  Do you have a simple formula for reproducing that?
If I'm correct, I suspect that autogen and/or bootstrap could be taught
how to recognize whether a 'git submodule update' was sufficient to sync
up to the expected version (the normal case) vs. still noticing that
.gnulib is dirty due to local changes (at least, I'm assuming that was
the situation you were in); in the latter case, it would then be fatal
with a message reminding you to commit your changes so that the
submodule is no longer dirty rather than inf-looping trying to sync up
something that won't change.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]