[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Managed save compression flags.

On 08/13/2010 09:06 AM, Daniel P. Berrange wrote:
> On Fri, Aug 13, 2010 at 10:53:48AM -0400, Chris Lalancette wrote:
>> Add in the ability to specify compression flags from the
>> managed save API.  We map these to the supported QEMU
>> compression flags internally.
> I'm not really convinced we need todo this. I think the host
> level setting in /etc/libvirt/qemu.conf is sufficient already.

But that's a global setting for all qemu domains.  I can see where it
might make sense to compression for some domains but not others, at
which point exposing the ability to suggest a non-default compression
makes sense.

On the other hand, if we agree that a qemu.conf setting is adequate,
then this patch still needs a respin, in order to honor the conf-file
default rather than hard-coding it to raw.

So either way, we need more discussion and probably a respin.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]