[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH 1/4: AppArmor updates

> Why do we need special behaviour to skip files which don't exist ?
> If this is solely to keep the test suite happy, then IMHO the
> fix should be in the test suite. Runtime production code shouldn't
> have workarounds for test code.

This is not to work around the test suite.

The intent is to help people migrating from < 0.8.3 to 0.8.3. When
considering the following binary states: file exists, disk format is
specified, ignoreOpenFailure and allowProbing, what is in trunk (ie
ignoreOpenFailure=true) and this patch work the same in all cases except
when the file does not exist and the format is not specified and
allowProbing=false (the new default). With what is in trunk, this is an
error condition, with my patch, the domain will start but the disk is
not added to the profile. Throwing an error because the format isn't
correct on a disk that doesn't exist seemed an odd side-effect when
migrating. I can see arguments against this, and would like to commit
the changes to tests/virt-aa-helper-test regardless.

Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]