[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] Try harder to send RPC error message back to client



On 08/17/2010 09:16 AM, Daniel P. Berrange wrote:
> @@ -558,22 +559,30 @@ remoteDispatchClientCall (struct qemud_server *server,
>                     msg->bufferLength,
>                     XDR_ENCODE);
>  
> -    if (xdr_setpos(&xdr, msg->bufferOffset) == 0)
> -        goto xdr_error;
> +    if (xdr_setpos(&xdr, msg->bufferOffset) == 0) {
> +        remoteDispatchFormatError(&rerr, "%s", _("failed to change XDR reply offset"));
> +	goto xdr_error;

Why the swap to a TAB?

ACK, modulo that nit.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]