[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add support for -enable-kqemu flag



On 08/17/2010 11:00 AM, Daniel P. Berrange wrote:
> Previously QEMU enabled KQEMU by default and had -no-kqemu.
> 0.11.x switched to requiring -enable-kqemu. 0.12.x dropped
> kqemu entirely. This patch adds support for -enable-kqemu
> so 0.11.x works. It replaces a huge set of if() with a
> switch() to make the code a bit more readable.
> 
> This patch was inspired by the one John Lumby send to the
> list a while ago, but the way I've implemented it is more
> in line with the logic we have for KVM.

ACK; although...

> +++ b/src/qemu/qemu_conf.h
> @@ -92,6 +92,7 @@ enum qemud_cmd_flags {
>      QEMUD_CMD_FLAG_PCI_CONFIGFD  = (1LL << 36), /* pci-assign.configfd */
>      QEMUD_CMD_FLAG_NODEFCONFIG   = (1LL << 37), /* -nodefconfig */
>      QEMUD_CMD_FLAG_BOOT_MENU     = (1LL << 38), /* -boot menu=on support */
> +    QEMUD_CMD_FLAG_ENABLE_KQEMU  = (1LL << 39), /* Is the -enable-kqemu flag available to "enable KQEMU full virtualization support" */

This is a long line for a comment; can we trim it to 80 columns?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]