[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Fix up qemu domain save/managed save locking.



On 08/16/10 - 10:17:09AM, Eric Blake wrote:
> On 08/13/2010 08:53 AM, Chris Lalancette wrote:
> > The current version of the qemu managed save implementation
> > is subject to a race where the domain shuts down between
> > the time that we start the command and the time that we
> > actually try to do the save.  Close this race by making
> > qemuDomainSaveFlags() expect both the driver and the passed-in
> > vm object to be locked before executing.
> > 
> > Signed-off-by: Chris Lalancette <clalance redhat com>
> > ---
> >  src/qemu/qemu_driver.c |   79 ++++++++++++++++++-----------------------------
> >  1 files changed, 30 insertions(+), 49 deletions(-)
> 
> ACK.

Thanks, I've pushed this one.  I'll wait on the other two until we finish
disucssing.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]