[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/7] Remote driver client and server for virDomainOpenConsole



On 08/17/2010 11:02 AM, Daniel P. Berrange wrote:
> This provides an implementation of the virDomainOpenConsole
> API for the remote driver client and server.
> 
> * daemon/remote.c: Server side impl
> * src/remote/remote_driver.c: Client impl
> * src/remote/remote_protocol.x: Wire definition
> ---
>  daemon/remote.c                     |   52 +++++++++++++++++
>  daemon/remote_dispatch_args.h       |    1 +
>  daemon/remote_dispatch_prototypes.h |    8 +++
>  daemon/remote_dispatch_table.h      |    5 ++
>  src/remote/remote_driver.c          |  108 ++++++++++++++++++++++++----------
>  src/remote/remote_protocol.c        |   13 ++++
>  src/remote/remote_protocol.h        |   10 +++
>  src/remote/remote_protocol.x        |    8 ++-
>  8 files changed, 172 insertions(+), 33 deletions(-)
> 

No change to src/remote_protocol-structs?  Install the dwarves package;
this will double-check that you aren't breaking any existing APIs, but
it will flag that this new call is an API addition worthy of an update
to src/remote_protocol-structs.


> @@ -9665,8 +9709,8 @@ processCallDispatchStream(virConnectPtr conn ATTRIBUTE_UNUSED,
>          privst = privst->next;
>  
>      if (!privst) {
> -        VIR_WARN("No registered stream matching serial=%d, proc=%d",
> -                 hdr->serial, hdr->proc);
> +        VIR_DEBUG("No registered stream matching serial=%d, proc=%d",
> +                  hdr->serial, hdr->proc);

Quite a few conversions from VIR_WARN to VIR_DEBUG in this patch.
Should they be split into a separate patch, since they are independent
of the new command plumbing?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]