[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] [PATCH 05/10] storage: avoid s[n]printf
- From: Matthias Bolte <matthias bolte googlemail com>
- To: Eric Blake <eblake redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [libvirt] [PATCH 05/10] storage: avoid s[n]printf
- Date: Thu, 19 Aug 2010 23:10:04 +0200
2010/8/19 Eric Blake <eblake redhat com>:
> * src/storage/storage_backend.c (virStorageBackendCreateQemuImg)
> (virStorageBackendCreateQcowCreate): Use virAsprintf instead.
> * src/storage/storage_backend_disk.c
> (virStorageBackendDiskCreateVol, virStorageBackendDiskPartFormat):
> Likewise.
> ---
>
> Things to look out for:
> virStorageBackendDiskPartFormat can now fail where it used to
> do nothing to the passed-in partFormat variable, if the switch
> statement hits the default.
>
Nice one, before it would just have executed parted with a random
string in the argumentlist in that case.
ACK.
Matthias
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]