[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] Change calling conventions in remote driver client internals



On Thu, Aug 19, 2010 at 01:50:43PM -0600, Eric Blake wrote:
> On 08/17/2010 11:02 AM, Daniel P. Berrange wrote:
> > The remoteIO() method has wierd calling conventions, where
> > it is passed a pre-allocated 'struct remote_call *' but
> > then free()s it itself, instead of letting the caller free().
> > This fixes those wierd semantics
> 
> s/wierd/weird/g
> 
> > 
> > * src/remote/remote_driver.c: Santize semantics of remoteIO
> 
> s/Santize/Sanitize/
> 
> >   method wrt to memory release
> > ---
> >  src/remote/remote_driver.c |   25 +++++++++++++------------
> >  1 files changed, 13 insertions(+), 12 deletions(-)
> 
> > @@ -10021,6 +10019,7 @@ call (virConnectPtr conn, struct private_data *priv,
> >        xdrproc_t ret_filter, char *ret)
> >  {
> >      struct remote_thread_call *thiscall;
> > +    int rv;
> 
> Any reason you used 'ret' in some hunks, but 'rv' in this one?

There is already a variable 'ret'  passed in as a parameter.
This is an unfortunate naming choice in the remote driver
code, but there's so many instances of it that it isn't
worth changing.

Daniel

-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]