[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Use structured PCI address as hash payload



> > Qemu driver stores a per-domain hash of used PCI addresses. Currently,
> > payload of each hash entry is exactly the same as its key, i.e., string
> > representation of a PCI address. This patch changes payload to be
> > virDomainDevicePCIAddressPtr. Along the road, return values of all
> > qemuPCIAddressAsString() calls are properly checked and error returned
> > if required.
> > ---
> >  src/qemu/qemu_conf.c |   78 ++++++++++++++++++++++++++++++++++++--------------
> >  1 files changed, 56 insertions(+), 22 deletions(-)
> 
> ACK.

NACK. I'm explicitly nacking the patch here to make it clear this patch was
not pushed intentionally. Most of the patch is not needed since 2/2 will not
by applied. The important parts of this patch were sent separately in small
non-invasive patches.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]