[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Ensure remote daemon unions are always non-zero length



On 08/24/2010 07:21 AM, Daniel P. Berrange wrote:
If the remote daemon args/ret unions ever become zero length
(due to a build / Makefile bug) then bad stuff happens at
runtime. Add a compile time assertion to check for this kind
of problem

* daemon/remote.h: Ensure non-zero length unions
---
  daemon/remote.h |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

ACK. It doesn't solve the parallel makefile race, but at least prevents us from proceeding to a broken executable.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]