[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Move libvirt-guests init script and config to tools

On 08/25/2010 06:33 AM, Jiri Denemark wrote:
Since libvirt-guests init script and its configuration do not require
libvirtd to be running/installed, it was a bad idea to put them into
daemon directory. libvirt.spec even includes these files in
libvirt-client subpackage, which may result in build failure for
client-only builds when the whole daemon directory is just skipped.
  daemon/Makefile.am            |   16 +--
  daemon/libvirt-guests.init.in |  341 -----------------------------------------
  daemon/libvirt-guests.sysconf |   24 ---
  tools/Makefile.am             |   41 +++++-
  tools/libvirt-guests.init.in  |  341 +++++++++++++++++++++++++++++++++++++++++
  tools/libvirt-guests.sysconf  |   24 +++
  6 files changed, 409 insertions(+), 378 deletions(-)
  delete mode 100644 daemon/libvirt-guests.init.in
  delete mode 100644 daemon/libvirt-guests.sysconf
  create mode 100644 tools/libvirt-guests.init.in
  create mode 100644 tools/libvirt-guests.sysconf

Using -M when generating the git diff would have been helpful (it would have compressed the file renames down to a couple of lines, leaving only the Makefile.am changes needing explicit review). In fact, since we don't have to cater to non-git patch programs when reviewing libvirt patches, you may want to run 'git config diff.renames true' to auto-set the -M option for future diffs.

At any rate, ACK.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]