[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Move libvirt-guests init script and config to tools



> >   daemon/Makefile.am            |   16 +--
> >   daemon/libvirt-guests.init.in |  341 -----------------------------------------
> >   daemon/libvirt-guests.sysconf |   24 ---
> >   tools/Makefile.am             |   41 +++++-
> >   tools/libvirt-guests.init.in  |  341 +++++++++++++++++++++++++++++++++++++++++
> >   tools/libvirt-guests.sysconf  |   24 +++
> >   6 files changed, 409 insertions(+), 378 deletions(-)
> >   delete mode 100644 daemon/libvirt-guests.init.in
> >   delete mode 100644 daemon/libvirt-guests.sysconf
> >   create mode 100644 tools/libvirt-guests.init.in
> >   create mode 100644 tools/libvirt-guests.sysconf
> 
> Using -M when generating the git diff would have been helpful (it would 
> have compressed the file renames down to a couple of lines, leaving only 
> the Makefile.am changes needing explicit review).  In fact, since we 
> don't have to cater to non-git patch programs when reviewing libvirt 
> patches, you may want to run 'git config diff.renames true' to auto-set 
> the -M option for future diffs.

Sorry about that and thanks for the tip. I already my configuration
accordingly.

> At any rate, ACK.

And pushed the patch.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]