[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: turn on gcc logical-op checking



On 07/26/2010 08:27 AM, Eric Blake wrote:
On 07/24/2010 02:36 PM, Matthias Bolte wrote:
+ * nuking the wrappers; even if it removes some type-check safety.  */
+# undef curl_easy_getinfo
+# undef curl_easy_setopt
+
  #define VIR_FROM_THIS VIR_FROM_ESX

No need to hack here. We can define CURL_DISABLE_TYPECHECK to disable
those type checks.

Yes, that sounds nicer.

Older gcc versions had a bug that meant the warnings in the libcurl header were spurious, since corrected in newer gcc, available in Rawhide. In the meantime, a newer libcurl release now available on Fedora 13 works around the older gcc bug. So, either way, should we remove CURL_DISABLE_TYPECHECK (effectively re-enabling the type safety), now that the spurious warnings are no longer triggered?

https://bugzilla.redhat.com/show_bug.cgi?id=617757

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]