[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: turn on gcc logical-op checking



2010/8/27 Eric Blake <eblake redhat com>:
> On 07/26/2010 08:27 AM, Eric Blake wrote:
>>
>> On 07/24/2010 02:36 PM, Matthias Bolte wrote:
>>>>
>>>> + * nuking the wrappers; even if it removes some type-check safety.  */
>>>> +# undef curl_easy_getinfo
>>>> +# undef curl_easy_setopt
>>>> +
>>>>  #define VIR_FROM_THIS VIR_FROM_ESX
>>>
>>> No need to hack here. We can define CURL_DISABLE_TYPECHECK to disable
>>> those type checks.
>>
>> Yes, that sounds nicer.
>
> Older gcc versions had a bug that meant the warnings in the libcurl header
> were spurious, since corrected in newer gcc, available in Rawhide.  In the
> meantime, a newer libcurl release now available on Fedora 13 works around
> the older gcc bug.  So, either way, should we remove CURL_DISABLE_TYPECHECK
> (effectively re-enabling the type safety), now that the spurious warnings
> are no longer triggered?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=617757
>

Well, even if this is fixed in GCC >= 4.5.0 and a workaround was added
to libcurl and Fedora isn't affected anymore doesn't mean that this
problem is fixed for all systems/distros out there.

I think we could remove CURL_DISABLE_TYPECHECK for GCC >= 4.5.0, but
keep it for older GCC versions.

I tried to figure out how to detect GCC version in configure.ac, but
my autotools-fu is weak today.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]