[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Fix generator for string return values



On 08/29/2010 05:00 PM, Matthias Bolte wrote:
Distinguish between strings as parameters (const char *)
and strings as return values (char **).

Here, you mention char**,

          if self.type == "String" and \
             self.occurrence not in [OCCURRENCE__REQUIRED_LIST,
                                     OCCURRENCE__OPTIONAL_LIST]:
-            return "const char *"
+            if self.is_return_value:
+                return "char *"

But here, it is only char*.  Which is it?

Other than that, I'm not very good with python (yet), so while I didn't spot anything glaringly wrong, I'm probably not the best reviewer.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]