[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use global directory as UML's monitorDir for privileged connections



On Wed, Aug 25, 2010 at 06:39:11PM +0200, Soren Hansen wrote:
> On 25-08-2010 18:07, Daniel P. Berrange wrote:
> >> --- a/src/uml/uml_driver.c
> >> +++ b/src/uml/uml_driver.c
> >> @@ -373,6 +373,10 @@ umlStartup(int privileged) {
> >>  
> >>          if ((base = strdup (SYSCONF_DIR "/libvirt")) == NULL)
> >>              goto out_of_memory;
> >> +
> >> +        if (virAsprintf(&uml_driver->monitorDir,
> >> +                        "%s/run/libvirt/uml", LOCAL_STATE_DIR) == -1)
> >> +            goto out_of_memory;
> > 
> > Can we make this  '%s/lib/libvirt/uml'
> 
> You want transient stuff like UNIX sockets in /var/lib? That seems odd
> to me.

Not hugely, but I don't want it to overlap with the directories
used by libvirtd for transient stuff. If we make it '%/run/libvirt/uml-guest'
instead that would be OK


> >> -    }
> >>  
> >> -    if (virAsprintf(&uml_driver->monitorDir,
> >> -                    "%s/.uml", userdir) == -1)
> >> -        goto out_of_memory;
> >> +        if (virAsprintf(&uml_driver->monitorDir,
> >> +                        "%s/.uml", userdir) == -1)
> >> +            goto out_of_memory;
> >> +    }
> > And   '%s/.libvirt/uml/lib' 
> 
> I understand your desire to be consistent, but I really think
> integrating well with existing management tools for the hypervisor (in
> this case uml-utilities) is more important.

Agreed, I hadn't seen your reply about uml-utilities when writing
this.

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]