[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix warning when macvtap support is disabled



On 12/01/2010 04:00 AM, Jean-Baptiste Rouault wrote:
> ---
>  src/qemu/qemu_conf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index b0343c6..7cd0603 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1689,6 +1689,7 @@ qemudPhysIfaceConnect(virConnectPtr conn,
>      (void)qemuCmdFlags;
>      (void)driver;
>      (void)vmuuid;
> +    (void)vmop;

Hmm; I'm wondering if it would be easier/more concise to use
ATTRIBUTE_UNUSED rather than explicit casts to void.  But it doesn't
bother me to leave it as-is.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]