[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 0/7] Support of auto-dump on watchdog event in libvirtd



On Wed, Dec 01, 2010 at 06:44:02PM -0700, Eric Blake wrote:
> On 12/01/2010 06:04 PM, Hu Tao wrote:
> > This patch series adds a new watchdog action `dump' which lets libvirtd
> > can do auto-dump when receiving a watchdog event from qemu guest.
> > 
> > In order to make the function work, there must be a watchdog device
> > added to guest, and guest must have a watchdog daemon running, for
> > example, /etc/init.d/watchdog start or auto-started on boot.
> > 
> > Changes:
> > 
> > v4:
> > 
> > - getCompressionType returns type of enum qemud_save_formats rather
> >   than int
> > - use virThread api in thread pool
> > - fix an error that qemuDomainObjBeginJobWithDriver() get lost in
> >   qemuDomainCoreDump()
> 
> You'll want to update to the latest libvirt.git, and rebase this series
> on top of that. 

Oops! I forgot to do a pull&rebase again.

> In particular, you don't need to commit any po/*.po
> file changes ('git checkout po' is the easiest way to undo those changes
> if running 'make' caused them to be regenerated), and patches 3 and 7
> have already been incorporated upstream, so they are no longer needed in
> your series.

While I was sending patch 2 I saw those POes and realized stg messed my
tree up and redid patch 2 before sending it.(But patch 0 was already
sent so those POes were listed there)

> 
> > Hu Tao (7):
> >   bug: local var referenced in another thread
> >   Add a threadpool implementation
> >   Fall back to QEMUD_SAVE_FORMAT_RAW if compression method fails.
> >   Add a new function doCoreDump
> >   Add a watchdog action `dump'
> >   Using threadpool API to manage qemud worker
> >   Add me to AUTHORS to make `make syntax-check' happy
> > 
> >  AUTHORS                    |    1 +
> >  cfg.mk                     |    3 +-
> >  daemon/libvirtd.c          |  168 +++++------------------------
> >  daemon/libvirtd.h          |    4 +
> >  po/af.po                   |   14 ++--
> >  po/am.po                   |   14 ++--
> 
> Hmm; this diffstat appears to include uncommitted changes on your HEAD,
> since none of the 7 commits actually included po changes.
> 
> -- 
> Eric Blake   eblake redhat com    +1-801-349-2682
> Libvirt virtualization library http://libvirt.org
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]