[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix a possible deadlock in p2p migration



On 12/03/2010 02:53 AM, Jiri Denemark wrote:
> Two more calls to remote libvirtd have to be surrounded by
> qemuDomainObjEnterRemoteWithDriver() and
> qemuDomainObjExitRemoteWithDriver() to prevent possible deadlock between
> two communicating libvirt daemons.
> 
> See commit f0c8e1cb3774d6f09e2681ca1988bf235a343007 for further details.
> ---
>  src/qemu/qemu_driver.c |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)

ACK.

> -    if (!VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
> -                                  VIR_DRV_FEATURE_MIGRATION_P2P)) {
> +
> +    qemuDomainObjEnterRemoteWithDriver(driver, vm);
> +    p2p = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
> +                                   VIR_DRV_FEATURE_MIGRATION_P2P);

Ah - this explains your patch for VIR_DRV_SUPPORTS_FEATURE; and this is
indeed a case where we want error to be equated with no feature support.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]