[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Change return value of VIR_DRV_SUPPORTS_FEATURE to bool



On 12/03/2010 08:36 AM, Jiri Denemark wrote:
>>> diff --git a/src/driver.h b/src/driver.h
>>> index b770e5e..e797a75 100644
>>> --- a/src/driver.h
>>> +++ b/src/driver.h
>>> @@ -52,12 +52,12 @@ typedef enum {
>>>   * Note that you must check for errors.
>>
>> However, this comment is no longer applicable.  So you'll need a v2 that
>> fixes the documentation, and make it explicit that the macro ignores
>> errors, as well as a cross-reference to the actual function for someone
>> that cares about errors.
> 
> Ah, I haven't noticed that line... What about the following v2?

ACK.

>  /* Internal feature-detection macro.  Don't call drv->supports_feature
> - * directly, because it may be NULL, use this macro instead.
> + * directly if you don't have to, because it may be NULL, use this macro
> + * instead.
>   *
> - * Note that you must check for errors.
> + * Note that this treats a possible error returned by drv->supports_feature
> + * the same as not supported. If you care about the error, call
> + * drv->supports_feature directly.
>   *

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]