[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: avoid shadowing devname() on BSD systems



On 04/12/2010, at 2:30 AM, Eric Blake wrote:
> * tools/virsh.c (cmdRunConsole, cmdConsole): Rename problematic
> symbol.
> Reported by Justin Clift.
> ---
>> IIRC, it had the same warning on FreeBSD, I just didn't post a patch for it yet.
> Pushing under the build-breaker rule, then.
> 
> tools/virsh.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)

Thanks Eric.  Captured the complete make log this time, to ensure it's fixed.

The same warning also appears in a few other places. :/

  libvirt.c: In function 'virDomainOpenConsole':
  libvirt.c:13169: warning: declaration of 'devname' shadows a global declaration [-Wshadow]
  /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]

  remote/remote_driver.c: In function 'remoteDomainOpenConsole':
  remote/remote_driver.c:9250: warning: declaration of 'devname' shadows a global declaration [-Wshadow]
  /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]

  console.c: In function 'vshRunConsole':
  console.c:279: warning: declaration of 'devname' shadows a global declaration [-Wshadow]
  /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]

  libvirt.c: In function 'libvirt_virDomainOpenConsole':
  libvirt.c:1255: warning: declaration of 'devname' shadows a global declaration [-Wshadow]
  /usr/include/stdlib.h:290: warning: shadowed declaration is here [-Wshadow]

While looking for those, a few more warnings also showed up:

  ../daemon/event.c: In function 'virEventInterruptLocked':
  ../daemon/event.c:656: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  virsh.c: In function 'vshReadlineInit':
  virsh.c:11575: warning: assignment discards qualifiers from pointer target type

  event.c: In function 'virEventInterruptLocked':
  event.c:656: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

Again though, they're warnings and don't stop the compilation from completing.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]