[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Remove redundant optional option for cmdHelp



On 04/12/2010, at 4:12 AM, Justin Clift wrote:
> On 04/12/2010, at 2:24 AM, Eric Blake wrote:
>> On 12/03/2010 12:34 AM, Osier Yang wrote:
>>> Remove the optional option "group", as cmdHelp should accepts
>>> only one option, and rename option "command" as "command-or-group",
>>> ("virsh help" supports both command and command group now, and user
>>> nealy uses the options, so it doesn't matter much for it being longer,
>>> :-)
>>> 
>>> * tools/virsh.c
>>> ---
>>> tools/virsh.c |    8 ++------
>>> 1 files changed, 2 insertions(+), 6 deletions(-)
>> 
>> Given the ensuing discussion, I'm pushing with this squashed in.
> 
> Thanks Eric, that works well.  I'll push a matching tweak to the man page in a
> minute too (under the trivial rule).

Actually, in this instance it's probably better if I submit it for ACKing rather than
just push it.  It should hit the list in a sec.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]