[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] smbios fixes



On Fri, Dec 03, 2010 at 03:15:11PM -0700, Eric Blake wrote:
> On 12/03/2010 02:50 AM, Gleb Natapov wrote:
> >>>>> I am surprised that libvirt still uses -uuid.
> 
> Why? It still works, and it's backwards compatible even to older qemu
> where -smbios wasn't supported.  It's actually harder to omit -uuid and
> use only -smbios, after first guaranteeing that -smbios is supported,
> than it is blindly use -uuid.  And since -uuid may have more
> implications than just the -smbios table, whereas -smbios should not
> affect anything except the smbios table, it makes sense to continue to
> use -uuid for any of those other implications.
> 
There is not any additional implication using -uuid. In fact -uuid and
-smbios table1,uuid= are completely identical from qemu's code point of
view since both of them set the same global variable qemu_uuid.

Currently there is not problem using both of them (with the same uuid
value of course) and I do not think this will change in the near
feature, so fixing libvirt to use only -smbios may be not the most
urgent bug to fix.

--
			Gleb.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]