[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 5/5] sysinfo: convert to virCommand



On Fri, Dec 03, 2010 at 02:56:18PM -0700, Eric Blake wrote:
> * src/util/sysinfo.c (virSysinfoRead): Use virCommand instead of
> virExec.
> ---
> 
> This patch assumes option 2 of my patch to virCommand guarantees on
> outbuf when the child process had no output (it needs a slight tweak
> to avoid a NULL dereference if we go with option 1 for virCommand).
> 
>  src/util/sysinfo.c |   50 ++++++++++----------------------------------------
>  1 files changed, 10 insertions(+), 40 deletions(-)

  Okay, fine by me, ACK

thanks for that nice patchset !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]